Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(router): flagged order_details validation to skip validation #3324

Merged
merged 4 commits into from
Jan 11, 2024
Merged

refactor(router): flagged order_details validation to skip validation #3324

merged 4 commits into from
Jan 11, 2024

Conversation

sahkal
Copy link
Contributor

@sahkal sahkal commented Jan 11, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

flagged order_details validation to skip validation
#3116

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@sahkal sahkal added P-high Priority: High S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor labels Jan 11, 2024
@sahkal sahkal added this to the December 2023 Release milestone Jan 11, 2024
@sahkal sahkal self-assigned this Jan 11, 2024
@sahkal sahkal requested a review from a team as a code owner January 11, 2024 08:38
@sahkal sahkal changed the title refactor(router): flagged order_details validation to skip validation Hotfix(router): flagged order_details validation to skip validation Jan 11, 2024
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jan 11, 2024
@sahkal sahkal changed the title Hotfix(router): flagged order_details validation to skip validation refactor(router): flagged order_details validation to skip validation Jan 11, 2024
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jan 11, 2024
@sahkal sahkal changed the title refactor(router): flagged order_details validation to skip validation refactor(router): flagged order_details validation to skip validation Jan 11, 2024
@sahkal sahkal requested a review from a team as a code owner January 11, 2024 09:18
bernard-eugine
bernard-eugine previously approved these changes Jan 11, 2024
View reviewed changes
@sahkal sahkal requested review from a team as code owners January 11, 2024 09:48
@sahkal sahkal requested a review from bernard-eugine January 11, 2024 09:51
SanchithHegde
SanchithHegde approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed clippy lint fixes, look good to me!

@SanchithHegde SanchithHegde merged commit b54603c into hotfix-1.105.0 Jan 11, 2024
10 of 12 checks passed
@SanchithHegde SanchithHegde deleted the flag-orderDetails-checks branch January 11, 2024 11:30
@SanchithHegde SanchithHegde removed the P-high Priority: High label Jan 11, 2024
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vspecky vspecky vspecky approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@Narayanbhat166 Narayanbhat166 Awaiting requested review from Narayanbhat166

@sai-harsha-vardhan sai-harsha-vardhan Awaiting requested review from sai-harsha-vardhan

@bernard-eugine bernard-eugine Awaiting requested review from bernard-eugine

Assignees

@sahkal sahkal

Labels
C-refactor Category: Refactor
Projects
None yet
Milestone
December 2023 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@sahkal @SanchithHegde @vspecky @bernard-eugine @Chethan-rao